Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Rename Mac clangd to Linux mac_clangd#51785

Merged
matanlurey merged 2 commits into
flutter-team-archive:mainfrom
matanlurey:clangd-v3
Mar 29, 2024
Merged

Rename Mac clangd to Linux mac_clangd#51785
matanlurey merged 2 commits into
flutter-team-archive:mainfrom
matanlurey:clangd-v3

Conversation

@matanlurey

Copy link
Copy Markdown
Contributor

Further work towards flutter/flutter#141641.

@matanlurey
matanlurey requested a review from zanderso March 29, 2024 20:31
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2024
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2024
@auto-submit

auto-submit Bot commented Mar 29, 2024

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/engine/51785, due to - The status or check suite Windows windows_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlurey
matanlurey merged commit 4b6836f into flutter-team-archive:main Mar 29, 2024
@matanlurey
matanlurey deleted the clangd-v3 branch March 29, 2024 21:19
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2024
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Mar 29, 2024
flutter-team-archive/engine@4c079a6...4b6836f

2024-03-29 matanlurey@users.noreply.github.com Rename `Mac clangd` to `Linux mac_clangd` (flutter-team-archive/engine#51785)
2024-03-29 matanlurey@users.noreply.github.com Fix the `clangd` builders, and make Linux non-bringup. (flutter-team-archive/engine#51765)
2024-03-29 magder@google.com Remove _dartobservatory._tcp legacy DNS registration type (flutter-team-archive/engine#51635)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants